Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: pkg/analyzer/lib/src/generated/error_verifier.dart

Issue 1568643002: clean up generic methods in resolution (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/element_resolver.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index 6e4638a5c6195548982a8424ab7feab56e925ce8..d644fcdcde55a0109c6066f2a8a71779e50be3f7 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -1360,12 +1360,12 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
// TODO(jmesserly): this duplicates some code in isSubtypeOf and most of
// _isGenericFunctionSubtypeOf. Ideally, we'd let TypeSystem produce
// an error message once it's ready to "return false".
- if (!overridingFT.boundTypeParameters.isEmpty) {
- if (overriddenFT.boundTypeParameters.isEmpty) {
+ if (!overridingFT.typeFormals.isEmpty) {
+ if (overriddenFT.typeFormals.isEmpty) {
overriddenFT = _typeSystem.instantiateToBounds(overriddenFT);
} else {
- List<TypeParameterElement> params1 = overridingFT.boundTypeParameters;
- List<TypeParameterElement> params2 = overriddenFT.boundTypeParameters;
+ List<TypeParameterElement> params1 = overridingFT.typeFormals;
+ List<TypeParameterElement> params2 = overriddenFT.typeFormals;
int count = params1.length;
if (params2.length != count) {
_errorReporter.reportErrorForNode(
« no previous file with comments | « pkg/analyzer/lib/src/generated/element_resolver.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698