For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy webkit_headless.

For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy webkit_headless.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1568633002

Committed: https://skia.googlesource.com/skia/+/85c8d06540942531fe3440fafa2a2825f128251a

[dogben, 2016-01-06 19:51:00]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[dogben, 2016-01-06 19:51:02]

Description was changed from

==========
For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy
webkit_headless.

BUG=skia:
==========

to

==========
For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy
webkit_headless.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-01-06 19:51:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568633002/1

[dogben, 2016-01-06 19:51:42]

benjaminwagner@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-06 19:53:33]

I take it this is a TODO, but it lets us roll?

If so, lgtm.

[mtklein, 2016-01-06 19:55:44]

Not necessarily TODO(benjaminwagner) mind you.

[commit-bot: I haz the power, 2016-01-06 20:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 20:11:04]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-01-06 20:28:19]

On 2016/01/06 at 19:53:33, mtklein wrote:
> I take it this is a TODO, but it lets us roll?
> 
> If so, lgtm.

No, it's not for the roll; it's needed by internal cl/107719535. (Sorry, I
forgot about this when you asked about interesting changes in that CL.)

In particular, see PlatformContextSkia::realizeSave. I can try to figure out how
to remove the dependency on SaveFlags, but it seemed like it would be simpler to
fix it after I submit cl/10771953.

[mtklein, 2016-01-06 20:29:53]

On 2016/01/06 20:28:19, Ben Wagner wrote:
> On 2016/01/06 at 19:53:33, mtklein wrote:
> > I take it this is a TODO, but it lets us roll?
> > 
> > If so, lgtm.
> 
> No, it's not for the roll; it's needed by internal cl/107719535. (Sorry, I
> forgot about this when you asked about interesting changes in that CL.)
> 
> In particular, see PlatformContextSkia::realizeSave. I can try to figure out
how
> to remove the dependency on SaveFlags, but it seemed like it would be simpler
to
> fix it after I submit cl/10771953.

Oh, gotcha.  SGTM

[dogben, 2016-01-06 20:32:44]

The CQ bit was checked by benjaminwagner@google.com

[dogben, 2016-01-06 20:32:44]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1568633002/#ps20001
(title: "Add TODO.")

[commit-bot: I haz the power, 2016-01-06 20:32:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568633002/20001

[commit-bot: I haz the power, 2016-01-06 20:52:02]

Description was changed from

==========
For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy
webkit_headless.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy
webkit_headless.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/85c8d06540942531fe3440fafa2a2825f128251a
==========

[commit-bot: I haz the power, 2016-01-06 20:52:03]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/85c8d06540942531fe3440fafa2a2825f128251a

[reed1, 2016-01-06 22:02:41]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-01-06 22:02:42]

FYI -- SaveFlags are planned to be actually removed (no flag option) as soon as
Florin works his magic in Android.... is that ok?

[mtklein, 2016-01-06 22:09:55]

On 2016/01/06 22:02:42, reed1 wrote:
> FYI -- SaveFlags are planned to be actually removed (no flag option) as soon
as
> Florin works his magic in Android.... is that ok?

We'll just need to port up the call sites in Google3.

[dogben, 2016-01-11 22:38:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1578033003/ by benjaminwagner@google.com.

The reason for reverting is: Removed legacy saveflags in internal cl/111889802..