Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 156863002: Revert of Add d8 to the chromium_builder_asan target. (Closed)

Created:
6 years, 10 months ago by Martin Barbella
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Add d8 to the chromium_builder_asan target. (https://codereview.chromium.org/142693006/) Reason for revert: This may be causing issues with runhooks. Reverting to be safe until I have time to investigate. Original issue's description: > Add d8 to the chromium_builder_asan target. > > BUG= > R=machenbach@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249433 TBR=machenbach@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Martin Barbella
Created Revert of Add d8 to the chromium_builder_asan target.
6 years, 10 months ago (2014-02-06 19:44:14 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 19:47:34 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-06 19:47:35 UTC) #3
aarya
lgtm
6 years, 10 months ago (2014-02-06 19:49:59 UTC) #4
inferno
lgtm
6 years, 10 months ago (2014-02-06 19:50:11 UTC) #5
Martin Barbella
The CQ bit was checked by mbarbella@chromium.org
6 years, 10 months ago (2014-02-06 19:51:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mbarbella@chromium.org/156863002/1
6 years, 10 months ago (2014-02-06 19:51:52 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 19:54:00 UTC) #8
Message was sent while issue was closed.
Change committed as 249474

Powered by Google App Engine
This is Rietveld 408576698