Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1568623004: [regexp] correctly parse non-BMP unicode escapes in atoms. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] correctly parse non-BMP unicode escapes in atoms. R=rossberg@chromium.org Committed: https://crrev.com/fbbb9cab45abcd03451abd9d4cb422ed4a7aacda Cr-Commit-Position: refs/heads/master@{#33207}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : rebase #

Patch Set 4 : rebase correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -4 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/scanner-character-streams.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-parser.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M test/cctest/test-regexp.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/unicode-escapes-in-regexps.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Yang
4 years, 11 months ago (2016-01-08 13:14:15 UTC) #1
rossberg
lgtm
4 years, 11 months ago (2016-01-11 12:13:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568623004/20001
4 years, 11 months ago (2016-01-11 12:13:30 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/12164) v8_linux64_avx2_rel on ...
4 years, 11 months ago (2016-01-11 12:14:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568623004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568623004/40001
4 years, 11 months ago (2016-01-11 13:06:22 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/12168)
4 years, 11 months ago (2016-01-11 13:18:36 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568623004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568623004/60001
4 years, 11 months ago (2016-01-11 13:45:15 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 14:16:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568623004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568623004/60001
4 years, 11 months ago (2016-01-11 14:17:04 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-11 14:18:32 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 14:19:29 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fbbb9cab45abcd03451abd9d4cb422ed4a7aacda
Cr-Commit-Position: refs/heads/master@{#33207}

Powered by Google App Engine
This is Rietveld 408576698