Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1568623002: Change cookbook to map target_arch to target_cpu (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change cookbook to map target_arch to target_cpu target_arch was listed as the gn equivalent of target_arch. This is wrong. BUG=570145 Committed: https://crrev.com/ff69eea6e2d53fab7acf55b3eb8cd554789feda2 Cr-Commit-Position: refs/heads/master@{#367912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/docs/cookbook.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Minor doc fix - PTAL.
4 years, 11 months ago (2016-01-06 19:47:50 UTC) #2
brettw
lgtm
4 years, 11 months ago (2016-01-06 20:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568623002/1
4 years, 11 months ago (2016-01-06 20:40:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 21:19:46 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 21:20:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff69eea6e2d53fab7acf55b3eb8cd554789feda2
Cr-Commit-Position: refs/heads/master@{#367912}

Powered by Google App Engine
This is Rietveld 408576698