unify how canvas checks for null on skia objects (images, blobs, pictures)

unify how canvas checks for null on skia objects (images, blobs, pictures)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1568613008

Committed: https://skia.googlesource.com/skia/+/e3b38ce43b5c5c6711e9cde4588e2bc15333c780

[reed1, 2016-01-08 16:27:37]

Description was changed from

==========
unify how canvas checks for null on skia objects (images, blobs, pictures)

BUG=skia:
==========

to

==========
unify how canvas checks for null on skia objects (images, blobs, pictures)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-08 16:27:53]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-01-08 16:27:56]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 16:28:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568613008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568613008/1

[commit-bot: I haz the power, 2016-01-08 16:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 16:31:00]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-01-08 16:44:19]

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:44: 
Aren't our macros usually all caps ?

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:838: bool SkCanvas::readPixels(SkBitmap* bitmap, int x,
int y) {
here too ?

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:865: bool SkCanvas::readPixels(const SkIRect& srcRect,
SkBitmap* bitmap) {
here ?

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:884: bool SkCanvas::readPixels(const SkImageInfo& dstInfo,
void* dstP, size_t rowBytes, int x, int y) {
here ?

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:921: }
here ?

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:1759: void SkCanvas::replayClips(ClipVisitor* visitor)
const {
here ?

[reed1, 2016-01-08 17:01:41]

For now I only want to check for objects that *we* return which may be null
(e.g. if the factory safely decides not to create something). Bitmaps are just
stack objects, so a null there is much more likely to be a caller error.

Also, today we have null checks for images pictures and blobs, but it wasn't
unified. This CL is intended to just solidify what we were already (mostly)
doing.

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/1568613008/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:44: 
On 2016/01/08 16:44:19, robertphillips wrote:
> Aren't our macros usually all caps ?

Done.

[reed1, 2016-01-08 17:02:44]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 17:02:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568613008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568613008/20001

[robertphillips, 2016-01-08 17:09:15]

lgtm

[reed1, 2016-01-08 17:10:36]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-01-08 17:10:39]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-01-08 17:10:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568613008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568613008/20001

[commit-bot: I haz the power, 2016-01-08 17:18:46]

Description was changed from

==========
unify how canvas checks for null on skia objects (images, blobs, pictures)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
unify how canvas checks for null on skia objects (images, blobs, pictures)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e3b38ce43b5c5c6711e9cde4588e2bc15333c780
==========

[commit-bot: I haz the power, 2016-01-08 17:18:47]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e3b38ce43b5c5c6711e9cde4588e2bc15333c780