Don't suppress compile-time errors when inlining.

Don't suppress compile-time errors when inlining.

When precompiling, it is possible to encounter a compile-time
error when inlining because the target never went through unoptimized
compilation or optimized compilation where it was the root function. Some checks
for compile-time errors are not idemponent because have they have
side-effects: in particular, the checks for a cyclic redirecting factory or
const expressions that have a runtime error may not trigger the second
time they are parsed.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/557978616132a989732895340642b6afaf68a52e

[rmacnak, 2016-01-07 23:56:32]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, vegorov@google.com

[Florian Schneider, 2016-01-14 00:53:02]

lgtm

[rmacnak, 2016-01-14 01:10:51]

Description was changed from

==========
Don't suppress compile-time errors when inlining.

When precompiling, it is possible to encounter a compile-time
error when inlining because the target never went through unoptimized
compilation or optimized compilation where it was the root function. Some checks
for compile-time errors are not idemponent because have they have
side-effects: in particular, the checks for a cyclic redirecting factory or
const expressions that have a runtime error may not trigger the second
time they are parsed.
==========

to

==========
Don't suppress compile-time errors when inlining.

When precompiling, it is possible to encounter a compile-time
error when inlining because the target never went through unoptimized
compilation or optimized compilation where it was the root function. Some checks
for compile-time errors are not idemponent because have they have
side-effects: in particular, the checks for a cyclic redirecting factory or
const expressions that have a runtime error may not trigger the second
time they are parsed.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/557978616132a989732895340642b6afaf68a52e
==========

[rmacnak, 2016-01-14 01:10:52]

Committed patchset #1 (id:1) manually as
557978616132a989732895340642b6afaf68a52e (presubmit successful).