Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1568613006: GN: Add dependencies from //content/renderer on WebRTC targets. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add dependencies from //content/renderer on WebRTC targets. These targets have headers included in //content/renderer, but which fail `gn check` because //content/renderer doesn't have a direct dependency on them. This resolves 16 errors in `gn check out/Default //content/renderer/*`. Committed: https://crrev.com/2bfe95637aaf49e60e7cd422d81eb4a9715cff80 Cr-Commit-Position: refs/heads/master@{#368439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/renderer/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbroman
R=piman for content/OWNERS CC=brettw FYI
4 years, 11 months ago (2016-01-08 15:09:12 UTC) #3
piman
lgtm
4 years, 11 months ago (2016-01-08 20:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568613006/1
4 years, 11 months ago (2016-01-08 20:42:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 21:55:22 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 21:56:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bfe95637aaf49e60e7cd422d81eb4a9715cff80
Cr-Commit-Position: refs/heads/master@{#368439}

Powered by Google App Engine
This is Rietveld 408576698