Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1568583005: Add proguard_verbose GN arg (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add proguard_verbose GN arg Useful when playing with proguard flags to be easily able to see all output & optimization summary. BUG=None Committed: https://crrev.com/94f77d25cd26ae685ad8c7c84403397e85fea7e7 Cr-Commit-Position: refs/heads/master@{#368424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M build/android/gyp/apk_obfuscate.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/gyp/proguard.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/gyp/util/proguard_util.py View 5 chunks +11 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/01/08 18:46:06, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org █████████ █████████
4 years, 11 months ago (2016-01-08 18:46:37 UTC) #3
Yaron
lgtm
4 years, 11 months ago (2016-01-08 19:07:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568583005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568583005/1
4 years, 11 months ago (2016-01-08 19:11:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 20:19:50 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 20:20:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94f77d25cd26ae685ad8c7c84403397e85fea7e7
Cr-Commit-Position: refs/heads/master@{#368424}

Powered by Google App Engine
This is Rietveld 408576698