Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: gpu/command_buffer/service/sync_point_manager_unittest.cc

Issue 1568563002: Added a way for sync point clients to issue out of order waits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow WaitOutOfOrder if no client order data Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/sync_point_manager_unittest.cc
diff --git a/gpu/command_buffer/service/sync_point_manager_unittest.cc b/gpu/command_buffer/service/sync_point_manager_unittest.cc
index 28321c433a173b686d79b79cf6ad9761a2fdba5b..cc67ff994cbab1200dbb33ce793d020e91a5d9e8 100644
--- a/gpu/command_buffer/service/sync_point_manager_unittest.cc
+++ b/gpu/command_buffer/service/sync_point_manager_unittest.cc
@@ -85,11 +85,19 @@ TEST_F(SyncPointManagerTest, BasicSyncPointOrderDataTest) {
EXPECT_EQ(order_num, order_data->current_order_num());
EXPECT_EQ(0u, order_data->processed_order_num());
EXPECT_EQ(order_num, order_data->unprocessed_order_num());
+ EXPECT_TRUE(order_data->IsProcessingOrderNumber());
+
+ order_data->PauseProcessingOrderNumber(order_num);
+ EXPECT_FALSE(order_data->IsProcessingOrderNumber());
+
+ order_data->BeginProcessingOrderNumber(order_num);
+ EXPECT_TRUE(order_data->IsProcessingOrderNumber());
order_data->FinishProcessingOrderNumber(order_num);
EXPECT_EQ(order_num, order_data->current_order_num());
EXPECT_EQ(order_num, order_data->processed_order_num());
EXPECT_EQ(order_num, order_data->unprocessed_order_num());
+ EXPECT_FALSE(order_data->IsProcessingOrderNumber());
}
TEST_F(SyncPointManagerTest, SyncPointClientRegistration) {
@@ -127,7 +135,11 @@ TEST_F(SyncPointManagerTest, BasicFenceSyncRelease) {
EXPECT_EQ(0u, client_state->fence_sync_release());
EXPECT_FALSE(client_state->IsFenceSyncReleased(1));
+ const uint32_t order_num =
+ order_data->GenerateUnprocessedOrderNumber(sync_point_manager_.get());
+ order_data->BeginProcessingOrderNumber(order_num);
client->ReleaseFenceSync(1);
+ order_data->FinishProcessingOrderNumber(order_num);
EXPECT_EQ(1u, client_state->fence_sync_release());
EXPECT_TRUE(client_state->IsFenceSyncReleased(1));
@@ -150,7 +162,11 @@ TEST_F(SyncPointManagerTest, MultipleClientsPerOrderData) {
scoped_refptr<SyncPointClientState> client_state1 = client1->client_state();
scoped_refptr<SyncPointClientState> client_state2 = client2->client_state();
+ const uint32_t order_num =
+ order_data->GenerateUnprocessedOrderNumber(sync_point_manager_.get());
+ order_data->BeginProcessingOrderNumber(order_num);
client1->ReleaseFenceSync(1);
+ order_data->FinishProcessingOrderNumber(order_num);
EXPECT_TRUE(client_state1->IsFenceSyncReleased(1));
EXPECT_FALSE(client_state2->IsFenceSyncReleased(1));
« no previous file with comments | « gpu/command_buffer/service/sync_point_manager.cc ('k') | gpu/command_buffer/tests/gl_fence_sync_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698