Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: content/common/gpu/gpu_command_buffer_stub.cc

Issue 1568563002: Added a way for sync point clients to issue out of order waits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: InProcessCommandBuffer::SignalSyncTokenOnGpuThread also waits out of order Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_command_buffer_stub.cc
diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc
index 8aabdca64837872060e04791d90e814e63f2cd0a..e30f81f735cf73773e79d5c77ed27fd2c159551d 100644
--- a/content/common/gpu/gpu_command_buffer_stub.cc
+++ b/content/common/gpu/gpu_command_buffer_stub.cc
@@ -1009,9 +1009,11 @@ void GpuCommandBufferStub::OnSignalSyncToken(const gpu::SyncToken& sync_token,
sync_token.namespace_id(), sync_token.command_buffer_id());
if (release_state) {
- sync_point_client_->Wait(release_state.get(), sync_token.release_count(),
- base::Bind(&GpuCommandBufferStub::OnSignalAck,
- this->AsWeakPtr(), id));
+ // This wait must use the out of order variant since it is not processed
+ // within the global order.
piman 2016/01/07 01:16:22 I don't think that's true, this is processed on th
David Yen 2016/01/07 18:40:58 You are right, this should be Wait instead of Wait
+ sync_point_client_->WaitOutOfOrder(
+ release_state.get(), sync_token.release_count(),
+ base::Bind(&GpuCommandBufferStub::OnSignalAck, this->AsWeakPtr(), id));
} else {
OnSignalAck(id);
}

Powered by Google App Engine
This is Rietveld 408576698