Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 1568553002: Update Crashpad to 54048cfd78af0a54cf4a2d2ecfb83881f5c54590 (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek, scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org, Avi (use Gerrit), tapted, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 54048cfd78af0a54cf4a2d2ecfb83881f5c54590 6d829e9af7d7 Create WorkerThread, an abstraction to perform some work on an interval 5e244711888b Fix build break after 6d829e9af7d7 18a294130552 Create the PruneCrashReportsThread in the handler c46a676624cf Use std::move() in PruneCrashReportThread 6d2d31d2d137 Use base/macros.h instead of base/basictypes.h b7e4564ff219 Update mini_chromium to a43fee120b10 54048cfd78af Don’t suppress_wildcard crashpad.gyp:All on platforms where it works Committed: https://crrev.com/b25d2d936da7620ff44ce4a2952f38402efad685 Cr-Commit-Position: refs/heads/master@{#367899}

Patch Set 1 #

Patch Set 2 : Fix GN build #

Patch Set 3 : OWN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -387 lines) Patch
A build/secondary/third_party/crashpad/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/README.chromium View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/capture_context_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_mac.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/prune_crash_reports.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/prune_crash_reports_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/client/settings_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/simple_string_dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/client/simulate_crash_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/simulate_crash_mac_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/crashpad.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/handler/crash_report_upload_thread.h View 5 chunks +11 lines, -15 lines 0 comments Download
M third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc View 5 chunks +14 lines, -60 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler.gyp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/mac/exception_handler_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/handler/prune_crash_reports_thread.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crashy_test_program.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_context_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_context_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_exception_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_exception_writer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_handle_writer.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_info_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_misc_info_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_misc_info_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_misc_info_writer_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_writer_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_rva_list_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_string_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_string_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_string_writer_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_system_info_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_system_info_writer_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_id_map_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_writable.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_writable.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_writable_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_writer_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_context_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_memory_writer_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_rva_list_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_writable_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/cpu_context_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/cpu_context_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/cpu_context_mac_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/exception_snapshot_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/thread_snapshot_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/memory_snapshot.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/test/test_cpu_context.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/test/test_memory_snapshot.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/cpu_context_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/memory_snapshot_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/module_snapshot_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_annotations_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_reader_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_reader_win_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/system_snapshot_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/thread_snapshot_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_exec_test_child.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_exec_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/tools/crashpad_database_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/tools/mac/catch_exception_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/tools/mac/exception_port_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/tools/tool_support.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/file/file_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/file/file_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/string_file.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/file/string_file_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mac/checked_mach_address_range.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mac/checked_mach_address_range_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mac/launchd.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mac/launchd_test.mm View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mac/mac_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mac/xattr.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_handshake.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/composite_mach_message_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/composite_mach_message_server_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_client_variants.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_client_variants_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_server_variants.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_server_variants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_server_variants_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_behaviors_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_ports.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_types_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/notify_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/notify_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/notify_server_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/scoped_task_suspend_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/symbolic_constants_mach.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/symbolic_constants_mach_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/task_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/mach/task_memory_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/misc/clock_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/misc/clock_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/misc/clock_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/misc/clock_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/misc/random_string_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/misc/uuid.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/misc/uuid_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_body.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_body_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_body_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_multipart_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_multipart_builder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_transport_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_transport_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/net/http_transport_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_address_range.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_range_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/numeric/int128_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/process_info_mac.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/process_info_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/posix/symbolic_constants_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/posix/symbolic_constants_posix_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/aligned_allocator_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/strlcpy.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/strlcpy_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/strnlen.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/strnlen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/string/split_string.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/synchronization/semaphore_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/thread/thread_log_messages.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/thread/thread_log_messages_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
A third_party/crashpad/crashpad/util/thread/worker_thread.h View 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/thread/worker_thread.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/thread/worker_thread_test.cc View 1 chunk +137 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/util_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/capture_context_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/command_line.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/command_line_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/exception_handler_server.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/ntstatus_logging.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/scoped_process_suspend_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/time.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:58:24 UTC) #2
Robert Sesek
rslgtm
4 years, 11 months ago (2016-01-06 18:03:03 UTC) #3
Robert Sesek
rs lgtm
4 years, 11 months ago (2016-01-06 18:03:15 UTC) #4
Mark Mentovai
“Robert Sesek looks good to [you]”
4 years, 11 months ago (2016-01-06 18:06:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568553002/1
4 years, 11 months ago (2016-01-06 18:13:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568553002/20001
4 years, 11 months ago (2016-01-06 19:17:06 UTC) #10
Mark Mentovai
scott for build/secondary/🖕
4 years, 11 months ago (2016-01-06 19:27:10 UTC) #12
scottmg
lgtm
4 years, 11 months ago (2016-01-06 19:36:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568553002/40001
4 years, 11 months ago (2016-01-06 19:39:33 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-06 20:42:53 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 20:44:06 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b25d2d936da7620ff44ce4a2952f38402efad685
Cr-Commit-Position: refs/heads/master@{#367899}

Powered by Google App Engine
This is Rietveld 408576698