Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 156853006: Revert exposing <dialog> in WebUI (Closed)

Created:
6 years, 10 months ago by falken
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert exposing <dialog> in WebUI The plan to use <dialog> in WebUI didn't work out. It was risky to use an experimental feature in Settings, especially as Chrome for iOS won't be able to use it. BUG=276825 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/render_view_impl.cc View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
falken
6 years, 10 months ago (2014-02-12 07:43:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-12 08:53:46 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 10 months ago (2014-02-12 08:56:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/156853006/1
6 years, 10 months ago (2014-02-12 08:59:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 11:36:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262387
6 years, 10 months ago (2014-02-12 11:36:59 UTC) #6
falken
The CQ bit was checked by falken@chromium.org
6 years, 10 months ago (2014-02-13 02:05:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/156853006/1
6 years, 10 months ago (2014-02-13 02:16:42 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:30:57 UTC) #9
Message was sent while issue was closed.
Change committed as 250986

Powered by Google App Engine
This is Rietveld 408576698