Issue 15685011: Properly catch user scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15685011: Properly catch user scripts (Closed)

Created:
7 years, 7 months ago by Devlin

Modified:
7 years, 7 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, Matt Perry, not at google - send to devlin

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Properly catch user scripts The problem was that we were setting converted_from_user_script_ after we referenced it within ContextScriptHandler::Parse(). BUG=242890 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201780

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/common/extensions/extension.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/15685011/1

7 years, 7 months ago (2013-05-23 00:59:19 UTC) #2

Message was sent while issue was closed.

Change committed as 201780