Find breakpoint by PC rather than source position when clearing breakpoint

Find breakpoint by PC rather than source position when clearing breakpoint

Current approach is to find breakpoint by the statement position that was used when setting breakpoint. This doesn't work when setting breakpoint by anything else but statement position.

(Question: could PC of existing breakpoint change, for example because of recompilation, or this approach is safe)

R=yangguo@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15021

[Yang, 2013-06-05 15:36:12]

On 2013/05/28 22:23:21, peter.rybin wrote:

LGTM.

[Peter.Rybin, 2013-06-07 11:36:11]

On 2013/06/05 15:36:12, Yang wrote:
> On 2013/05/28 22:23:21, peter.rybin wrote:
> 
> LGTM.

Hi Yang,

since I completely missed to send you https://codereview.chromium.org/15737023/
for review, FindBreakLocationFromAddress still has "weird" semantics, so my
change actually must be as in the new patch "plus one": it adds "1" to pointer
to overcome "weird" semantics.

Tests confirm this is a right thing to do.

Hope you are ok with this.

Peter

[Peter.Rybin, 2013-06-09 20:10:35]

Committed patchset #3 manually as r15021.