Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: remoting/webapp/client_screen.js

Issue 15685008: Show a 'remember me' checkbox in the web-app when connecting to a host that supports pairing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improved PIN dialog layout. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/client_screen.js
diff --git a/remoting/webapp/client_screen.js b/remoting/webapp/client_screen.js
index ffd745cf1c358151b77b0123514c16f99a43bb1d..bd74bfe83d9985b1cd1c3a3d28f6494d17c01a2d 100644
--- a/remoting/webapp/client_screen.js
+++ b/remoting/webapp/client_screen.js
@@ -265,8 +265,11 @@ remoting.connectMe2MeHostVersionAcknowledged_ = function(host) {
thirdPartyTokenFetcher.fetchToken();
};
- /** @param {function(string):void} onPinFetched */
- var requestPin = function(onPinFetched) {
+ /**
+ * @param {function(string):void} onPinFetched
+ * @param {boolean} supportsPairing
+ */
+ var requestPin = function(onPinFetched, supportsPairing) {
rmsousa 2013/05/23 00:14:59 Nit: Does javascript also have the convention of p
Jamie 2013/05/23 01:10:08 Done.
/** @type {Element} */
var pinForm = document.getElementById('pin-form');
/** @type {Element} */
@@ -296,6 +299,11 @@ remoting.connectMe2MeHostVersionAcknowledged_ = function(host) {
pinForm.addEventListener('submit', onSubmitOrCancel, false);
pinCancel.addEventListener('click', onSubmitOrCancel, false);
+ var rememberPin = document.getElementById('remember-pin');
+ rememberPin.hidden = !supportsPairing;
+ var checkbox = /** @type {HTMLInputElement} */
+ document.getElementById('remember-pin-checkbox');
+ checkbox.checked = false;
var message = document.getElementById('pin-message');
l10n.localizeElement(message, host.hostName);
remoting.setMode(remoting.AppMode.CLIENT_PIN_PROMPT);

Powered by Google App Engine
This is Rietveld 408576698