Show a 'remember me' checkbox in the web-app when connecting to a host that supports pairing.

remoting/webapp/client_screen.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to the 'client screen' for Chromoting.
  */
 
 'use strict';
@@ skipping 247 matching lines @@
    * @param {function(string, string):void} onThirdPartyTokenFetched Callback.
    */
   var fetchThirdPartyToken = function(
       tokenUrl, hostPublicKey, scope, onThirdPartyTokenFetched) {
     var thirdPartyTokenFetcher = new remoting.ThirdPartyTokenFetcher(
         tokenUrl, hostPublicKey, scope, host.tokenUrlPatterns,
         onThirdPartyTokenFetched);
     thirdPartyTokenFetcher.fetchToken();
   };
 
-  /** @param {function(string):void} onPinFetched */
-  var requestPin = function(onPinFetched) {
+  /**
+   * @param {function(string):void} onPinFetched
+   * @param {boolean} supportsPairing
+   */
+  var requestPin = function(onPinFetched, supportsPairing) {

[rmsousa, 2013/05/23 00:14:59]

Nit: Does javascript also have the convention of putting the callback last? If
so, please do.

[Jamie, 2013/05/23 01:10:08]

Done.

     /** @type {Element} */
     var pinForm = document.getElementById('pin-form');
     /** @type {Element} */
     var pinCancel = document.getElementById('cancel-pin-entry-button');
     /**
      * Event handler for both the 'submit' and 'cancel' actions. Using
      * a single handler for both greatly simplifies the task of making
      * them one-shot. If separate handlers were used, each would have
      * to unregister both itself and the other.
      *
      * @param {Event} event The click or submit event.
      */
     var onSubmitOrCancel = function(event) {
       pinForm.removeEventListener('submit', onSubmitOrCancel, false);
       pinCancel.removeEventListener('click', onSubmitOrCancel, false);
       var pinField = document.getElementById('pin-entry');
       var pin = pinField.value;
       pinField.value = '';
       if (event.target == pinForm) {
         event.preventDefault();
         remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
         onPinFetched(pin);

[rmsousa, 2013/05/23 00:14:59]

Nit: add todo here

[Jamie, 2013/05/23 01:10:08]

To check the state of the checkbox? That's actually done post-connection, and
it's only part of a larger CL, so I don't think it's worth calling out that
specific part as a TODO. It's also likely to be the next CL I'm landing.

[rmsousa, 2013/05/23 21:17:52]

For the next CL: I think it's better to save the checkbox state here (say, to
remoting.clientSession), and then use that saved state post-connection, rather
than going back to the checkbox UI element directly, long after the dialog was
closed.

       } else {
         remoting.setMode(remoting.AppMode.HOME);
       }
     };
     pinForm.addEventListener('submit', onSubmitOrCancel, false);
     pinCancel.addEventListener('click', onSubmitOrCancel, false);
 
+    var rememberPin = document.getElementById('remember-pin');
+    rememberPin.hidden = !supportsPairing;
+    var checkbox = /** @type {HTMLInputElement} */
+        document.getElementById('remember-pin-checkbox');
+    checkbox.checked = false;
     var message = document.getElementById('pin-message');
     l10n.localizeElement(message, host.hostName);
     remoting.setMode(remoting.AppMode.CLIENT_PIN_PROMPT);
   };
   remoting.connector.connectMe2Me(host, requestPin, fetchThirdPartyToken);
 };
 
 /** @param {remoting.ClientSession} clientSession */
 remoting.onConnected = function(clientSession) {
   remoting.clientSession = clientSession;
   remoting.clientSession.setOnStateChange(onClientStateChange_);
   setConnectionInterruptedButtonsText_();
   var connectedTo = document.getElementById('connected-to');
   connectedTo.innerText = clientSession.hostDisplayName;
   remoting.setMode(remoting.AppMode.IN_SESSION);
   remoting.toolbar.center();
   remoting.toolbar.preview();
   remoting.clipboard.startSession();
   updateStatistics_();
 };