Show a 'remember me' checkbox in the web-app when connecting to a host that supports pairing.

remoting/webapp/client_plugin_async.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class that wraps low-level details of interacting with the client plugin.
  *
  * This abstracts a <embed> element and controls the plugin which does
  * the actual remoting work. It also handles differences between
@@ skipping 32 matching lines @@
   /**
    * @param {string} tokenUrl Token-request URL, received from the host.
    * @param {string} hostPublicKey Public key for the host.
    * @param {string} scope OAuth scope to request the token for.
    */
   this.fetchThirdPartyTokenHandler = function(
     tokenUrl, hostPublicKey, scope) {};
   this.onDesktopSizeUpdateHandler = function () {};
   /** @param {!Array.<string>} capabilities The negotiated capabilities. */
   this.onSetCapabilitiesHandler = function (capabilities) {};
-  this.fetchPinHandler = function () {};
+  this.fetchPinHandler = function (supportsPairing) {};
 
   /** @type {number} */
   this.pluginApiVersion_ = -1;
   /** @type {Array.<string>} */
   this.pluginApiFeatures_ = [];
   /** @type {number} */
   this.pluginApiMinVersion_ = -1;
   /** @type {!Array.<string>} */
   this.capabilities_ = [];
   /** @type {boolean} */
@@ skipping 192 matching lines @@
       remoting.clientSession.onFirstFrameReceived();
     }
   } else if (message.method == 'onConnectionReady') {
     if (typeof message.data['ready'] != 'boolean') {
       console.error('Received incorrect onConnectionReady message.');
       return;
     }
     var ready = /** @type {boolean} */ message.data['ready'];
     this.onConnectionReadyHandler(ready);
   } else if (message.method == 'fetchPin') {
-    this.fetchPinHandler();
+    var pairingSupported =
+        /** @type {boolean} */ message.data['pairingSupported'];
+    if (pairingSupported !== undefined &&

[rmsousa, 2013/05/23 00:14:59]

Nit: I think it's clearer to explicitly test for 'pairingSupported' in
message.data (and add a comment saying that this is valid for messages from
older client plugins), and then do error handling.

Regardless of style, please ensure that pairingSupported always holds a boolean
(not undefined).

[Jamie, 2013/05/23 01:10:08]

Done.

+        typeof pairingSupported != 'boolean') {
+      console.error('Received incorrect fetchPin message.');
+      return;
+    }
+    this.fetchPinHandler(pairingSupported);
   } else if (message.method == 'setCapabilities') {
     if (typeof message.data['capabilities'] != 'string') {
       console.error('Received incorrect setCapabilities message.');
       return;
     }
 
     /** @type {!Array.<string>} */
     var capabilities = tokenize(message.data['capabilities']);
     this.onSetCapabilitiesHandler(capabilities);
   } else if (message.method == 'fetchThirdPartyToken') {
@@ skipping 290 matching lines @@
     this.plugin.width = width;
     this.plugin.height = height;
     // Center the plugin just underneath the "Connnecting..." dialog.
     var parentNode = this.plugin.parentNode;
     var dialog = document.getElementById('client-dialog');
     var dialogRect = dialog.getBoundingClientRect();
     parentNode.style.top = (dialogRect.bottom + 16) + 'px';
     parentNode.style.left = (window.innerWidth - width) / 2 + 'px';
   }
 };