Show a 'remember me' checkbox in the web-app when connecting to a host that supports pairing.

remoting/protocol/negotiating_client_authenticator.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/negotiating_client_authenticator.h"
 
 #include <algorithm>
 #include <sstream>
 
 #include "base/bind.h"
@@ skipping 107 matching lines @@
     // |ThirdPartyClientAuthenticator| takes ownership of |token_fetcher_|.
     // The authentication method negotiation logic should guarantee that only
     // one |ThirdPartyClientAuthenticator| will need to be created per session.
     DCHECK(token_fetcher_);
     current_authenticator_.reset(new ThirdPartyClientAuthenticator(
         token_fetcher_.Pass()));
     resume_callback.Run();
   } else {
     DCHECK(current_method_.type() == AuthenticationMethod::SPAKE2 ||
            current_method_.type() == AuthenticationMethod::SPAKE2_PAIR);
-    // TODO(jamiewalch): Add a bool parameter to the fetch secret callback to
-    // indicate whether or not to show the "remember me" checkbox. Set it to
-    // (current_method_.type() == AuthenticationMethod::SPAKE2_PAIR).
-    fetch_secret_callback_.Run(base::Bind(
+    bool pairing_supported =
+        (current_method_.type() == AuthenticationMethod::SPAKE2_PAIR);
+    SecretFetchedCallback callback = base::Bind(
         &NegotiatingClientAuthenticator::CreateV2AuthenticatorWithSecret,
-        weak_factory_.GetWeakPtr(), preferred_initial_state, resume_callback));
+        weak_factory_.GetWeakPtr(), preferred_initial_state, resume_callback);
+    fetch_secret_callback_.Run(pairing_supported, callback);
   }
 }
 
 void NegotiatingClientAuthenticator::CreatePreferredAuthenticator() {
   if (!client_pairing_id_.empty() && !shared_secret_.empty() &&
       std::find(methods_.begin(), methods_.end(),
                 AuthenticationMethod::Spake2Pair()) != methods_.end()) {
     // If the client specified a pairing id and shared secret, then create a
     // PairingAuthenticator.
     current_authenticator_.reset(new PairingClientAuthenticator(
         client_pairing_id_, shared_secret_, fetch_secret_callback_,
         authentication_tag_));
     current_method_ = AuthenticationMethod::Spake2Pair();
   }
 }
 
 void NegotiatingClientAuthenticator::CreateV2AuthenticatorWithSecret(
     Authenticator::State initial_state,
     const base::Closure& resume_callback,
     const std::string& shared_secret) {
   current_authenticator_ = V2Authenticator::CreateForClient(
       AuthenticationMethod::ApplyHashFunction(
           current_method_.hash_function(), authentication_tag_, shared_secret),
       initial_state);
   resume_callback.Run();
 }
 
 }  // namespace protocol
 }  // namespace remoting