src/compiler/interpreter-assembler.h - Issue 1568493002: [Interpreter] Add support for calling runtime functions which return a pair.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/interpreter-assembler.h

Issue 1568493002: [Interpreter] Add support for calling runtime functions which return a pair. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address Michi's review comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/interpreter-assembler.h

diff --git a/src/compiler/interpreter-assembler.h b/src/compiler/interpreter-assembler.h

index b5e93e7ef6b131976d642e8fa70cb6555fa16986..fb79d3eaa2ff2a506faf3cb3cbd2e6f91b767b74 100644

--- a/src/compiler/interpreter-assembler.h

+++ b/src/compiler/interpreter-assembler.h

@@ -67,6 +67,9 @@ class InterpreterAssembler {

Node* StoreRegister(Node* value, interpreter::Register reg);

Node* StoreRegister(Node* value, Node* reg_index);

+ // Returns the next consecutive register.

+ Node* NextRegister(Node* reg_index);

// Returns the location in memory of the register |reg_index| in the

// interpreter register file.

Node* RegisterLocation(Node* reg_index);

@@ -130,7 +133,8 @@ class InterpreterAssembler {

Node* arg2, Node* arg3, Node* arg4, Node* arg5);

// Call runtime function.

- Node* CallRuntime(Node* function_id, Node* first_arg, Node* arg_count);

+ Node* CallRuntime(Node* function_id, Node* first_arg, Node* arg_count,

+ int return_size = 1);

Node* CallRuntime(Runtime::FunctionId function_id, Node* arg1);

Node* CallRuntime(Runtime::FunctionId function_id, Node* arg1, Node* arg2);

Node* CallRuntime(Runtime::FunctionId function_id, Node* arg1, Node* arg2,

« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | src/compiler/interpreter-assembler.cc » ('j') | no next file with comments »