chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc - Issue 156843004: Remove ExtensionService::extension_prefs()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Issue 156843004: Remove ExtensionService::extension_prefs() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: additional cleanup Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc ('K') | « chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc ('k') | chrome/browser/ui/webui/extensions/extension_info_ui.cc » ('j') | chrome/browser/ui/webui/extensions/extension_info_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

index d0d9449413d586ec3223e0785f29ed3883709446..9d5d491b034d26f45becca668c0324bd8ec637a5 100644

--- a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

+++ b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

@@ -8,7 +8,6 @@

#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"

#include "chrome/browser/extensions/browser_action_test_util.h"

#include "chrome/browser/extensions/extension_browsertest.h"

James Cook 2014/02/07 00:53:02 nit: include extension_prefs.h

Ken Rockot(use gerrit already) 2014/02/10 18:53:02 Done.

-#include "chrome/browser/extensions/extension_service.h"

#include "content/public/test/test_utils.h"

using extensions::Extension;

@@ -181,8 +180,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, ForceHide) {

// Force hide this browser action.

extensions::ExtensionActionAPI::SetBrowserActionVisibility(

- extensions::ExtensionSystem::Get(browser()->profile())->

- extension_service()->extension_prefs(),

+ extensions::ExtensionPrefs::Get(browser()->profile()),

idA,

false);

EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions());