Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: net/spdy/hpack/hpack_decoder.h

Issue 1568423002: Implement better HPACK Huffman code decoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not use binary literals. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/fuzzing/hpack_fuzz_util.cc ('k') | net/spdy/hpack/hpack_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_decoder.h
diff --git a/net/spdy/hpack/hpack_decoder.h b/net/spdy/hpack/hpack_decoder.h
index 85c7f2b5b344c6a0948a394a5093ce89c7ca329d..da6162d7f3748169294c84c9851b7225a2b6ea65 100644
--- a/net/spdy/hpack/hpack_decoder.h
+++ b/net/spdy/hpack/hpack_decoder.h
@@ -25,8 +25,6 @@
namespace net {
-class HpackHuffmanTable;
-
namespace test {
class HpackDecoderPeer;
} // namespace test
@@ -35,9 +33,7 @@ class NET_EXPORT_PRIVATE HpackDecoder {
public:
friend class test::HpackDecoderPeer;
- // |table| is an initialized HPACK Huffman table, having an
- // externally-managed lifetime which spans beyond HpackDecoder.
- explicit HpackDecoder(const HpackHuffmanTable& table);
+ HpackDecoder();
~HpackDecoder();
// Called upon acknowledgement of SETTINGS_HEADER_TABLE_SIZE.
@@ -102,9 +98,7 @@ class NET_EXPORT_PRIVATE HpackDecoder {
std::string headers_block_buffer_;
SpdyHeaderBlock decoded_block_;
- // Huffman table to be applied to decoded Huffman literals,
- // and scratch space for storing those decoded literals.
- const HpackHuffmanTable& huffman_table_;
+ // Scratch space for storing decoded literals.
std::string key_buffer_, value_buffer_;
// If non-NULL, handles decoded headers.
« no previous file with comments | « net/spdy/fuzzing/hpack_fuzz_util.cc ('k') | net/spdy/hpack/hpack_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698