Implement better HPACK Huffman code decoder.

net/spdy/hpack/hpack_huffman_table.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_HPACK_HUFFMAN_TABLE_H_
 #define NET_SPDY_HPACK_HUFFMAN_TABLE_H_
 
 #include <stdint.h>
 
 #include <cstddef>
@@ skipping 64 matching lines @@
   // Returns whether Initialize() has been successfully called.
   bool IsInitialized() const;
 
   // Encodes the input string to the output stream using the table's Huffman
   // context.
   void EncodeString(base::StringPiece in, HpackOutputStream* out) const;
 
   // Returns the encoded size of the input string.
   size_t EncodedSize(base::StringPiece in) const;
 
-  // Decodes symbols from |in| into |out|. It is the caller's responsibility
-  // to ensure |out| has a reserved a sufficient buffer to hold decoded output.
-  // DecodeString() halts when |in| runs out of input, in which case true is
-  // returned. It also halts (returning false) if an invalid Huffman code
-  // prefix is read, or if |out_capacity| would otherwise be overflowed.
-  bool DecodeString(HpackInputStream* in,
-                    size_t out_capacity,
-                    std::string* out) const;
+  // Decodes symbols from |in| into |out|, using the support for generic (any)
+  // huffman tables, not just those defined in the HPACK spec. It is the
+  // caller's responsibility to ensure |out| has reserved a sufficient buffer to
+  // hold decoded output. GenericDecodeString() halts when |in| runs out of
+  // input, in which case true is returned. It also halts (returning false) if
+  // an invalid Huffman code prefix is read, or if |out_capacity| would
+  // otherwise be overflowed.
+  // DEPRECATED: HpackHuffmanDecoder is now used for decoding strings encoded
+  // according to the Huffman Table in the HPACK spec.
+  bool GenericDecodeString(HpackInputStream* in,
+                           size_t out_capacity,
+                           std::string* out) const;
 
  private:
   // Expects symbols ordered on length & ID ascending.
   void BuildDecodeTables(const std::vector<Symbol>& symbols);
 
   // Expects symbols ordered on ID ascending.
   void BuildEncodeTable(const std::vector<Symbol>& symbols);
 
   // Adds a new DecodeTable with the argument prefix & indexed length.
   // Returns the new table index.
@@ skipping 17 matching lines @@
   uint8_t pad_bits_;
 
   // If initialization fails, preserve the symbol ID which failed validation
   // for examination in tests.
   uint16_t failed_symbol_id_;
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_HPACK_HUFFMAN_TABLE_H_