ui/views/controls/textfield/textfield.cc - Issue 15684004: Refine Views textfield state interaction, testing, and examples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 15684004: Refine Views textfield state interaction, testing, and examples. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add and expand on comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 73cdb48853d26058f02399f41e855469e00984b4..b5aa80bfe28694bad943926d0e66cec338b057e3 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -128,8 +128,8 @@ TextfieldController* Textfield::GetController() const {

}

void Textfield::SetReadOnly(bool read_only) {

+ // Update read-only without changing the focusable state (or active, etc.).

read_only_ = read_only;

- set_focusable(!read_only);

if (native_wrapper_) {

native_wrapper_->UpdateReadOnly();

native_wrapper_->UpdateTextColor();