Preserve page resize information when main frame is remote

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1884 matching lines @@
     view->setTopControlsViewportAdjustment(topControlsViewportAdjustment / minimumPageScaleFactor());
 }
 
 TopControls& WebViewImpl::topControls()
 {
     return page()->frameHost().topControls();
 }
 
 void WebViewImpl::resizeViewWhileAnchored(FrameView* view)
 {
-    // FIXME: TextAutosizer does not yet support out-of-process frames.
-    if (mainFrameImpl() && mainFrameImpl()->frame()->isLocalFrame()) {
+    ASSERT(mainFrameImpl() && mainFrameImpl()->frame()->isLocalFrame());
+
+    {
         // Avoids unnecessary invalidations while various bits of state in TextAutosizer are updated.
         TextAutosizer::DeferUpdatePageInfo deferUpdatePageInfo(page());
         performResize();
-    } else {
-        performResize();
     }
 
     m_fullscreenController->updateSize();
 
     // Relayout immediately to recalculate the minimum scale limit for rotation anchoring.
     if (view->needsLayout())
         view->layout();
 }
 
 void WebViewImpl::resize(const WebSize& newSize)
 {
     if (m_shouldAutoResize || m_size == newSize)
         return;
 
+    if (page()->mainFrame() && !page()->mainFrame()->isLocalFrame()) {
+        // Viewport resize for a remote main frame does not require any
+        // particular action, but the state needs to reflect the correct size
+        // so that it can be used for initalization if the main frame gets
+        // swapped to a LocalFrame at a later time.
+        m_size = newSize;
+        pageScaleConstraintsSet().didChangeViewSize(m_size);

[bokan, 2016/01/11 18:18:58]

Is this call to didChangeViewSize actually needed to make your case work?
pageScaleConstraintsSet is responsible for calculating min/max page scales and
layout width. I doubt it'll work as expected since it also needs the content
width which a remote process wont have, so unless you needed this I'd remove it.

[kenrb, 2016/01/11 20:50:26]

The original test case on https://crbug.com/526211 results in a page being
rendered with incorrect size without this line. When we are swapping from remote
to a local main frame we don't necessarily get a resize after the swap has
completed, so not updating the pageScaleConstraintsSet on the resize that we get
before the frame swap still affects rendering.

[bokan, 2016/01/11 20:52:53]

Ok, sgtm

+        page()->frameHost().visualViewport().setSize(m_size);
+        return;
+    }
+
     WebLocalFrameImpl* mainFrame = mainFrameImpl();
     if (!mainFrame)
         return;
 
     FrameView* view = mainFrame->frameView();
     if (!view)
         return;
 
     VisualViewport& visualViewport = page()->frameHost().visualViewport();
 
@@ skipping 2690 matching lines @@
 void WebViewImpl::detachPaintArtifactCompositor()
 {
     if (!m_layerTreeView)
         return;
 
     m_layerTreeView->setDeferCommits(true);
     m_layerTreeView->clearRootLayer();
 }
 
 } // namespace blink