[iOS] Allow overriding icuctl.dat file location.

[iOS] Allow overriding icuctl.dat file location.

This allows for iOS to only ship one icuctl.dat file for the main bundle
and for the today extension.

BUG=

Committed: https://crrev.com/b83910dc8dc2457740ad0ef6de03218ae11ddc47
Cr-Commit-Position: refs/heads/master@{#368461}

[rohitrao (ping after 24h), 2016-01-08 17:47:05]

rohitrao@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-01-08 17:47:05]

https://codereview.chromium.org/1568363002/diff/1/base/i18n/icu_util.cc
File base/i18n/icu_util.cc (right):

https://codereview.chromium.org/1568363002/diff/1/base/i18n/icu_util.cc#newco...
base/i18n/icu_util.cc:17: #include "base/ios/ios_util.h"
This should go between the OS_ANDROID and OS_MAC blocks below.

[justincohen, 2016-01-08 17:56:52]

Description was changed from

==========
[iOS] Allow overriding icuctl.dat file location.

BUG=
==========

to

==========
[iOS] Allow overriding icuctl.dat file location.

This allows for iOS to only ship one icuctl.dat file for the main bundle
and for the today extension.

BUG=
==========

[justincohen, 2016-01-08 17:58:57]

justincohen@chromium.org changed reviewers:
+ mark@chromium.org

[justincohen, 2016-01-08 17:58:57]

PTAL!

[Mark Mentovai, 2016-01-08 18:03:20]

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm
File base/ios/ios_util.mm (right):

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm#ne...
base/ios/ios_util.mm:14: namespace {
Blank line after this, since there’s more than just this function in the
namespace now.

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm#ne...
base/ios/ios_util.mm:24: static NSString* g_icudtl_path_override = nil;
You don’t need static, you’re already in an unnamed namespace.

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm#ne...
base/ios/ios_util.mm:57: g_icudtl_path_override = [[NSString
stringWithUTF8String:path] copy];
Why are you saving this as an NSString* when it’s a char* on the way in and a
FilePath on the way out? Seems like encoding/decoding for nothing. How about
“std::string* g_icudtl_path_override = nullptr” above, and then
“g_icudtl_path_override = new std::string(path);” here?

[justincohen, 2016-01-08 18:16:52]

Done, ptal!

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm
File base/ios/ios_util.mm (right):

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm#ne...
base/ios/ios_util.mm:14: namespace {
On 2016/01/08 18:03:20, Mark Mentovai wrote:
> Blank line after this, since there’s more than just this function in the
> namespace now.

Done.

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm#ne...
base/ios/ios_util.mm:24: static NSString* g_icudtl_path_override = nil;
On 2016/01/08 18:03:20, Mark Mentovai wrote:
> You don’t need static, you’re already in an unnamed namespace.

Done.

https://codereview.chromium.org/1568363002/diff/20001/base/ios/ios_util.mm#ne...
base/ios/ios_util.mm:57: g_icudtl_path_override = [[NSString
stringWithUTF8String:path] copy];
On 2016/01/08 18:03:20, Mark Mentovai wrote:
> Why are you saving this as an NSString* when it’s a char* on the way in and a
> FilePath on the way out? Seems like encoding/decoding for nothing. How about
> “std::string* g_icudtl_path_override = nullptr” above, and then
> “g_icudtl_path_override = new std::string(path);” here?

Done.

[Mark Mentovai, 2016-01-08 18:18:26]

LGTM

[rohitrao (ping after 24h), 2016-01-08 21:42:25]

lgtm

[justincohen, 2016-01-08 21:42:33]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-01-08 21:43:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568363002/40001

[commit-bot: I haz the power, 2016-01-08 23:49:52]

Description was changed from

==========
[iOS] Allow overriding icuctl.dat file location.

This allows for iOS to only ship one icuctl.dat file for the main bundle
and for the today extension.

BUG=
==========

to

==========
[iOS] Allow overriding icuctl.dat file location.

This allows for iOS to only ship one icuctl.dat file for the main bundle
and for the today extension.

BUG=
==========

[commit-bot: I haz the power, 2016-01-08 23:49:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-08 23:51:08]

Description was changed from

==========
[iOS] Allow overriding icuctl.dat file location.

This allows for iOS to only ship one icuctl.dat file for the main bundle
and for the today extension.

BUG=
==========

to

==========
[iOS] Allow overriding icuctl.dat file location.

This allows for iOS to only ship one icuctl.dat file for the main bundle
and for the today extension.

BUG=

Committed: https://crrev.com/b83910dc8dc2457740ad0ef6de03218ae11ddc47
Cr-Commit-Position: refs/heads/master@{#368461}
==========

[commit-bot: I haz the power, 2016-01-08 23:51:09]

Patchset 3 (id:??) landed as
https://crrev.com/b83910dc8dc2457740ad0ef6de03218ae11ddc47
Cr-Commit-Position: refs/heads/master@{#368461}