Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1568353002: Don't test directly against Scanner::kNoSourcePos instead use >= 0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc
index e9b180820a2cce8ad82032e56540268da39a607f..e3b0fcf41cc5b1783c3de820e09dd698c0de4b21 100644
--- a/runtime/vm/flow_graph_compiler_ia32.cc
+++ b/runtime/vm/flow_graph_compiler_ia32.cc
@@ -1369,7 +1369,7 @@ Condition FlowGraphCompiler::EmitEqualityRegConstCompare(
} else {
__ Call(*StubCode::UnoptimizedIdenticalWithNumberCheck_entry());
}
- if (token_pos != Scanner::kNoSourcePos) {
+ if (token_pos >= 0) {
AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall,
Thread::kNoDeoptId,
token_pos);
@@ -1396,7 +1396,7 @@ Condition FlowGraphCompiler::EmitEqualityRegRegCompare(Register left,
} else {
__ Call(*StubCode::UnoptimizedIdenticalWithNumberCheck_entry());
}
- if (token_pos != Scanner::kNoSourcePos) {
+ if (token_pos >= 0) {
AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall,
Thread::kNoDeoptId,
token_pos);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698