Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1568343002: Support for writing Int32 lists. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support for writing Int32 lists. We have one List<int> in the summaries model, so we need to be able to write these lists in FlatBuffers. We could probably make it more general by adding the Writer interface and use it for writing any lists, as well as replace specialized methods like addInt32() or addInt8() with a general addScalarField(). But this will make clients code a little bigger. Thoughts? R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/26c6fc36e4db19767b46d4ec8158c29dede290b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 3 chunks +22 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-08 17:30:01 UTC) #1
Paul Berry
lgtm. I think keeping the code compact and non-general is reasonable for now. We can ...
4 years, 11 months ago (2016-01-08 17:45:36 UTC) #2
scheglov
4 years, 11 months ago (2016-01-08 18:41:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26c6fc36e4db19767b46d4ec8158c29dede290b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698