Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1568293002: [swarming] Isolate static initializer check. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Isolate static initializer check. BUG=chromium:535160 LOG=n Committed: https://crrev.com/835813c38c8da894f1268b6f17c05aaaec3857cc Cr-Commit-Position: refs/heads/master@{#33176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/check-static-initializers.gyp View 1 chunk +5 lines, -5 lines 0 comments Download
A + tools/check-static-initializers.isolate View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Achenbach
PTAL
4 years, 11 months ago (2016-01-08 12:34:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568293002/1
4 years, 11 months ago (2016-01-08 12:34:21 UTC) #5
tandrii(chromium)
lgtm
4 years, 11 months ago (2016-01-08 12:47:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568293002/1
4 years, 11 months ago (2016-01-08 12:48:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 12:58:19 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 12:58:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/835813c38c8da894f1268b6f17c05aaaec3857cc
Cr-Commit-Position: refs/heads/master@{#33176}

Powered by Google App Engine
This is Rietveld 408576698