Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1568263003: Changes top level window creation to include window state in callback (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes top level window creation to include window state in callback Without this the client and server may be out of sync. BUG=none TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/1a47e17ba2160a8100406b71beb4584ddf5432e6 Cr-Commit-Position: refs/heads/master@{#368464}

Patch Set 1 #

Patch Set 2 : better comments #

Patch Set 3 : fix gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -6 lines) Patch
M components/mus/public/cpp/lib/window_private.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 chunks +64 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 3 chunks +125 lines, -1 line 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 2 chunks +6 lines, -1 line 0 comments Download
M components/mus/ws/test_change_tracker.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/mus/ws/test_change_tracker.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 11 months ago (2016-01-08 18:13:26 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 11 months ago (2016-01-08 22:38:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568263003/40001
4 years, 11 months ago (2016-01-08 22:44:22 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-08 23:52:13 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 23:54:12 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a47e17ba2160a8100406b71beb4584ddf5432e6
Cr-Commit-Position: refs/heads/master@{#368464}

Powered by Google App Engine
This is Rietveld 408576698