Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1568213002: DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types. A singleton static local cannot refer to a Blink garbage collected object directly, as that fails to keep the singleton alive. A strong off-heap persistent reference, a Persistent<> variant or a persistent collection type, is required. Add a static assert which catches out such incorrect uses of GCed types. R=haraken BUG= Committed: https://crrev.com/6a4cb616366c7ad3a9b969ab52774a11e4dd1cf8 Cr-Commit-Position: refs/heads/master@{#368313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/heap/Handle.h View 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/StdLibExtras.h View 2 chunks +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraits.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 11 months ago (2016-01-08 08:03:41 UTC) #2
haraken
LGTM
4 years, 11 months ago (2016-01-08 08:09:15 UTC) #3
sof
See https://build.chromium.org/p/tryserver.blink/builders/linux_blink_oilpan_dbg/builds/2320/steps/compile%20%28with%20patch%29/logs/stdio for an example of what it catches. (That issue is addressed by https://codereview.chromium.org/1562353004/ ...
4 years, 11 months ago (2016-01-08 09:27:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568213002/1
4 years, 11 months ago (2016-01-08 10:52:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 12:04:30 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 12:05:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a4cb616366c7ad3a9b969ab52774a11e4dd1cf8
Cr-Commit-Position: refs/heads/master@{#368313}

Powered by Google App Engine
This is Rietveld 408576698