DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=haraken
BUG=

Committed: https://crrev.com/6a4cb616366c7ad3a9b969ab52774a11e4dd1cf8
Cr-Commit-Position: refs/heads/master@{#368313}

[sof, 2016-01-08 08:03:40]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-01-08 08:03:41]

please take a look.

[haraken, 2016-01-08 08:09:15]

LGTM

[sof, 2016-01-08 09:27:43]

See
https://build.chromium.org/p/tryserver.blink/builders/linux_blink_oilpan_dbg/...
for an example of what it catches.

(That issue is addressed by https://codereview.chromium.org/1562353004/ )

[sof, 2016-01-08 10:52:24]

Description was changed from

==========
DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=
BUG=
==========

to

==========
DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=haraken
BUG=
==========

[sof, 2016-01-08 10:52:38]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-01-08 10:52:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568213002/1

[commit-bot: I haz the power, 2016-01-08 12:04:30]

Description was changed from

==========
DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=haraken
BUG=
==========

to

==========
DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=haraken
BUG=
==========

[commit-bot: I haz the power, 2016-01-08 12:04:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-08 12:05:40]

Description was changed from

==========
DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=haraken
BUG=
==========

to

==========
DEFINE_STATIC_LOCAL(): assert against illegal use of GCed types.

A singleton static local cannot refer to a Blink garbage collected
object directly, as that fails to keep the singleton alive. A
strong off-heap persistent reference, a Persistent<> variant
or a persistent collection type, is required.

Add a static assert which catches out such incorrect uses of
GCed types.

R=haraken
BUG=

Committed: https://crrev.com/6a4cb616366c7ad3a9b969ab52774a11e4dd1cf8
Cr-Commit-Position: refs/heads/master@{#368313}
==========

[commit-bot: I haz the power, 2016-01-08 12:05:40]

Patchset 1 (id:??) landed as
https://crrev.com/6a4cb616366c7ad3a9b969ab52774a11e4dd1cf8
Cr-Commit-Position: refs/heads/master@{#368313}