Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: content/renderer/render_view_impl.cc

Issue 15682009: Eliminate SwapOut message parameters, keeping state in RVHM instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index c7cd9fb7b9a3f9891c563c72cdf264c8c8b73fa3..1faa023d825c1014a3b048bbb284824e1addbd31 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -5583,7 +5583,7 @@ void RenderViewImpl::OnShouldClose() {
before_unload_end_time));
}
-void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
+void RenderViewImpl::OnSwapOut() {
// Only run unload if we're not swapped out yet, but send the ack either way.
if (!is_swapped_out_) {
// Swap this RenderView out so the tab can navigate to a page rendered by a
@@ -5616,8 +5616,7 @@ void RenderViewImpl::OnSwapOut(const ViewMsg_SwapOut_Params& params) {
webview()->setVisibilityState(WebKit::WebPageVisibilityStateHidden, false);
}
- // Just echo back the params in the ACK.
- Send(new ViewHostMsg_SwapOut_ACK(routing_id_, params));
+ Send(new ViewHostMsg_SwapOut_ACK(routing_id_));
}
void RenderViewImpl::NavigateToSwappedOutURL(WebKit::WebFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698