Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1568103003: Specializations of instance methods have non-null receiver. (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Specializations of instance methods have non-null receiver. A null check is inserted before the inlined code. This occasionally removes a few null checks at inlining sites within the inlinee. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/aa85691dddd0dc36d96bb10c694cdfe4058d56d0

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M pkg/compiler/lib/src/cps_ir/inline.dart View 1 4 chunks +23 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
sra1
4 years, 11 months ago (2016-01-07 23:41:05 UTC) #3
Kevin Millikin (Google)
lgtm
4 years, 11 months ago (2016-01-08 00:16:14 UTC) #4
sra1
4 years, 11 months ago (2016-01-08 19:59:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
aa85691dddd0dc36d96bb10c694cdfe4058d56d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698