Issue 15681004: Revert "Make Object.freeze fast"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15681004: Revert "Make Object.freeze fast" (Closed)

Created:
7 years, 7 months ago by adamk

Modified:
7 years, 7 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Make Object.freeze fast" and "Fix Object.freeze on dictionary-backed arrays to properly freeze elements" This reverts r14758 and r14759 due to introducing failures in Test262 TBR=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14760

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -365 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/objects.h	View	6 chunks	+5 lines, -19 lines	0 comments	Download
M	src/objects.cc	View	15 chunks	+62 lines, -211 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/property-details.h	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	src/v8natives.js	View	1 chunk	+12 lines, -19 lines	0 comments	Download
M	test/mjsunit/object-freeze.js	View	2 chunks	+0 lines, -68 lines	0 comments	Download

Total messages: 2 (0 generated)

adamk

7 years, 7 months ago (2013-05-22 21:27:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r14760 (presubmit successful).