mojo/shell/application_instance.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/application_instance.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/application_instance.cc

diff --git a/mojo/shell/application_instance.cc b/mojo/shell/application_instance.cc

index 0d709afd6832291972e346334851674f96fbc6b9..8c3003dd60ea0f97dbfb77668d46abae05334213 100644

--- a/mojo/shell/application_instance.cc

+++ b/mojo/shell/application_instance.cc

@@ -101,7 +101,7 @@ void ApplicationInstance::ConnectToApplication(

scoped_ptr<ConnectToApplicationParams> params(

new ConnectToApplicationParams);

params->SetSource(this);

- GURL app_url(app_request->url);

+ GURL app_url(app_request->url.get());

params->SetTargetURLRequest(

std::move(app_request),

Identity(app_url, std::string(), capability_filter));