mojo/runner/android/android_handler.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/runner/android/android_handler.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/runner/android/android_handler.cc

diff --git a/mojo/runner/android/android_handler.cc b/mojo/runner/android/android_handler.cc

index 55522d4a65e243652ecfdae938f56d1121378297..1495a067f2e0708767f66350c95f7ad16ea549de 100644

--- a/mojo/runner/android/android_handler.cc

+++ b/mojo/runner/android/android_handler.cc

@@ -141,7 +141,7 @@ void AndroidHandler::RunApplication(

if (!response->url.is_null()) {

base::FilePath internal_app_path;

base::FilePath path_to_mojo;

- if (IsCachedApp(env, GURL(response->url), &internal_app_path,

+ if (IsCachedApp(env, GURL(response->url.get()), &internal_app_path,

&path_to_mojo)) {

ScopedJavaLocalRef<jstring> j_internal_app_path(

ConvertUTF8ToJavaString(env, internal_app_path.value()));

« no previous file with comments | « media/mojo/services/mojo_cdm_service.cc ('k') | mojo/services/network/url_loader_impl.cc » ('j') | no next file with comments »