Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 9119c5712fa26e496dbd9bdc301a726f474231e4..ecf84b8497268228ed2081936fc0a32aacfd959e 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -42,6 +42,7 @@
#include "content/renderer/service_worker/service_worker_type_util.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_message_macros.h"
+#include "third_party/WebKit/public/platform/URLConversion.h"
#include "third_party/WebKit/public/platform/WebCrossOriginServiceWorkerClient.h"
#include "third_party/WebKit/public/platform/WebMessagePortChannel.h"
#include "third_party/WebKit/public/platform/WebPassOwnPtr.h"
@@ -448,10 +449,8 @@ void ServiceWorkerContextClient::reportException(
int column_number,
const blink::WebString& source_url) {
Send(new EmbeddedWorkerHostMsg_ReportException(
- embedded_worker_id_,
- error_message,
- line_number,
- column_number, GURL(source_url)));
+ embedded_worker_id_, error_message, line_number, column_number,
+ blink::WebStringToGURL(source_url)));
}
void ServiceWorkerContextClient::reportConsoleMessage(
@@ -465,7 +464,7 @@ void ServiceWorkerContextClient::reportConsoleMessage(
params.message_level = level;
params.message = message;
params.line_number = line_number;
- params.source_url = GURL(source_url);
+ params.source_url = blink::WebStringToGURL(source_url);
Send(new EmbeddedWorkerHostMsg_ReportConsoleMessage(
embedded_worker_id_, params));
« no previous file with comments | « content/renderer/renderer_blink_platform_impl.cc ('k') | content/renderer/shared_worker/embedded_shared_worker_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698