content/renderer/drop_data_builder.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/drop_data_builder.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/drop_data_builder.cc

diff --git a/content/renderer/drop_data_builder.cc b/content/renderer/drop_data_builder.cc

index beb98b6dec2c20976ec126df03a6d89024dac9cd..232428b5891004d3a4b611335b393707c17966a4 100644

--- a/content/renderer/drop_data_builder.cc

+++ b/content/renderer/drop_data_builder.cc

@@ -8,6 +8,7 @@

#include "base/strings/string_util.h"

#include "content/public/common/drop_data.h"

+#include "third_party/WebKit/public/platform/URLConversion.h"

#include "third_party/WebKit/public/platform/WebDragData.h"

#include "third_party/WebKit/public/platform/WebString.h"

#include "third_party/WebKit/public/platform/WebVector.h"

@@ -34,7 +35,7 @@ DropData DropDataBuilder::Build(const WebDragData& drag_data) {

break;

}

if (base::EqualsASCII(str_type, ui::Clipboard::kMimeTypeURIList)) {

- result.url = GURL(item.stringData);

+ result.url = blink::WebStringToGURL(item.stringData);

result.url_title = item.title;

break;

}