content/browser/navigator_connect/service_port_service_impl.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/navigator_connect/service_port_service_impl.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/navigator_connect/service_port_service_impl.cc

diff --git a/content/browser/navigator_connect/service_port_service_impl.cc b/content/browser/navigator_connect/service_port_service_impl.cc

index 310c304ab3e09e057c44550b91980935f114f5a5..73ea2793ed43573ac6a024ef1be775752f1808eb 100644

--- a/content/browser/navigator_connect/service_port_service_impl.cc

+++ b/content/browser/navigator_connect/service_port_service_impl.cc

@@ -91,7 +91,7 @@ void ServicePortServiceImpl::Connect(const mojo::String& target_url,

const mojo::String& origin,

const ConnectCallback& callback) {

navigator_connect_context_->Connect(

- GURL(target_url), GURL(origin), this,

+ GURL(target_url.get()), GURL(origin.get()), this,

base::Bind(&ServicePortServiceImpl::OnConnectResult,

weak_ptr_factory_.GetWeakPtr(), callback));

}