components/web_view/frame.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/frame.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_view/frame.cc

diff --git a/components/web_view/frame.cc b/components/web_view/frame.cc

index 62dca5a822e347f21185623a439169334912a924..453382ba53d2fe0f940f137359931accc7b56326 100644

--- a/components/web_view/frame.cc

+++ b/components/web_view/frame.cc

@@ -362,7 +362,7 @@ void Frame::StartNavigate(mojo::URLRequestPtr request) {

DVLOG(2) << "Frame::StartNavigate id=" << id_ << " url=" << request->url;

- const GURL requested_url(request->url);

+ const GURL requested_url(request->url.get());

base::TimeTicks navigation_start_time =

base::TimeTicks::FromInternalValue(request->originating_time_ticks);

tree_->delegate_->CanNavigateFrame(