Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/worker_content_settings_client_proxy.cc ('k') | components/web_view/frame.cc » ('j') | third_party/WebKit/Source/platform/exported/URLConversion.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index b7bb401283b71181d22bfac68733b61a2f0ec5e5..0f761664462bfa27f57c937e21c7cad1217d74d1 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -20,6 +20,7 @@
#include "components/autofill/core/common/autofill_util.h"
#include "components/autofill/core/common/form_data.h"
#include "components/autofill/core/common/form_field_data.h"
+#include "third_party/WebKit/public/platform/URLConversion.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebVector.h"
#include "third_party/WebKit/public/web/WebDocument.h"
@@ -1419,7 +1420,7 @@ bool WebFormElementToFormData(
// If the completed URL is not valid, just use the action we get from
// WebKit.
if (!form->action.is_valid())
- form->action = GURL(form_element.action());
+ form->action = GURL(blink::WebStringToGURL(form_element.action()));
WebVector<WebFormControlElement> control_elements;
form_element.getFormControlElements(control_elements);
« no previous file with comments | « chrome/renderer/worker_content_settings_client_proxy.cc ('k') | components/web_view/frame.cc » ('j') | third_party/WebKit/Source/platform/exported/URLConversion.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698