components/web_view/pending_web_view_load.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/pending_web_view_load.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Mojo issues Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_view/pending_web_view_load.cc

diff --git a/components/web_view/pending_web_view_load.cc b/components/web_view/pending_web_view_load.cc

index a86aa0c5d429103d590fa5fd4d3cbebecc2040e6..d5db3543b7bbf3a9e79ed88afe9f1c2c1dda1d04 100644

--- a/components/web_view/pending_web_view_load.cc

+++ b/components/web_view/pending_web_view_load.cc

@@ -20,7 +20,7 @@ PendingWebViewLoad::~PendingWebViewLoad() {}

void PendingWebViewLoad::Init(mojo::URLRequestPtr request) {

DCHECK(!frame_connection_);

- pending_url_ = GURL(request->url);

+ pending_url_ = GURL(request->url.get());

navigation_start_time_ =

base::TimeTicks::FromInternalValue(request->originating_time_ticks);

frame_connection_.reset(new FrameConnection);