Reduce string copies in GURL creation

third_party/WebKit/public/platform/WebString.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
     }
 
     WebString& operator=(const base::string16& s)
     {
         assign(s.data(), s.length());
         return *this;
     }
 
     operator base::string16() const
     {
-        return base::Latin1OrUTF16ToUTF16(length(), data8(), data16());
+        return base::Latin1OrUTF16ToUTF16(length(), data8OrNull(), data16OrNull());
     }
 
     WebString(const base::NullableString16& s)
     {
         if (s.is_null())
             reset();
         else
             assign(s.string().data(), s.string().length());
     }
 
     WebString& operator=(const base::NullableString16& s)
     {
         if (s.is_null())
             reset();
         else
             assign(s.string().data(), s.string().length());
         return *this;
     }
 
     operator base::NullableString16() const
     {
         return base::NullableString16(operator base::string16(), m_private.isNull());
     }
 #endif
 
+    BLINK_COMMON_EXPORT bool is8Bit() const;
+
+    // Returns the 8- or 16-bit underlying string buffer. If the buffer is not
+    // the corresponding type, null will be returned.
+    BLINK_COMMON_EXPORT const WebLChar* data8OrNull() const;

[esprehn, 2016/01/07 23:56:23]

Yeah I don't want to expose this.  All this patch does is point out even harder
that chromium should be using WTF::String. That would have meant no copies in
the first place. :)

You could add a GURL converter for WebURL?

+    BLINK_COMMON_EXPORT const WebUChar* data16OrNull() const;
+
 private:
-    BLINK_COMMON_EXPORT bool is8Bit() const;
-    BLINK_COMMON_EXPORT const WebLChar* data8() const;
-    BLINK_COMMON_EXPORT const WebUChar* data16() const;
-
     BLINK_COMMON_EXPORT void assign(WTF::StringImpl*);
 
     WebPrivatePtr<WTF::StringImpl> m_private;
 };
 
 inline bool operator==(const WebString& a, const char* b)
 {
     return a.equals(b);
 }
 
@@ skipping 18 matching lines @@
 }
 
 inline bool operator!=(const WebString& a, const WebString& b)
 {
     return !(a == b);
 }
 
 } // namespace blink
 
 #endif