third_party/mozilla/BUILD.gn - Issue 1568073002: Reduce string copies in GURL creation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/mozilla/BUILD.gn

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 component("mozilla") {	5 component("mozilla") {

6 sources = [	6 sources = [

7 "ComplexTextInputPanel.h",	7 "ComplexTextInputPanel.h",

8 "ComplexTextInputPanel.mm",	8 "ComplexTextInputPanel.mm",

9 "MozillaExport.h",	9 "MozillaExport.h",

10 "NSPasteboard+Utils.h",	10 "NSPasteboard+Utils.h",

11 "NSPasteboard+Utils.mm",	11 "NSPasteboard+Utils.mm",

12 "NSScreen+Utils.h",	12 "NSScreen+Utils.h",

13 "NSScreen+Utils.m",	13 "NSScreen+Utils.m",

14 "NSString+Utils.h",	14 "NSString+Utils.h",

15 "NSString+Utils.mm",	15 "NSString+Utils.mm",

16 "NSURL+Utils.h",	16 "NSURL+Utils.h",

17 "NSURL+Utils.m",	17 "NSURL+Utils.m",

18 "NSWorkspace+Utils.h",	18 "NSWorkspace+Utils.h",

19 "NSWorkspace+Utils.m",	19 "NSWorkspace+Utils.m",

20 ]	20 ]

21	21

22 defines = [ "MOZILLA_IMPLEMENTATION" ]	22 defines = [ "MOZILLA_IMPLEMENTATION" ]

23	23

24 deps = [	24 deps = [

	25 "//base",

25 "//url",	26 "//url",

26 ]	27 ]

27	28

28 if (is_component_build && (is_mac \|\| is_ios)) {	29 if (is_component_build && (is_mac \|\| is_ios)) {

29 # Needed to link to Obj-C static libraries.	30 # Needed to link to Obj-C static libraries.

30 ldflags = [ "-Wl,-ObjC" ]	31 ldflags = [ "-Wl,-ObjC" ]

31 }	32 }

32 }	33 }

OLD	NEW