Reduce string copies in GURL creation

third_party/WebKit/Source/platform/exported/URLConversion.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "public/platform/URLConversion.h"
+
+#include "public/platform/WebString.h"
+#include "url/gurl.h"
+#include "wtf/text/StringUTF8Adaptor.h"
+#include "wtf/text/WTFString.h"
+
+namespace blink {
+
+GURL WebStringToGURL(const WebString& webStr)

[esprehn, 2016/01/14 01:47:59]

webString

+{
+    WTF::String str = webStr;

[esprehn, 2016/01/14 01:47:59]

no need for WTF:: prefix.

also wtfString, don't abbreviate in blink please.

+    if (str.is8Bit()) {
+        // Ensure the (possibly Latin-1) 8-bit string is UTF-8 for GURL.
+        WTF::StringUTF8Adaptor utf8(str);
+        return GURL(utf8.asStringPiece());

[esprehn, 2016/01/14 01:47:59]

Note that this isn't safe unless the GURL copies the string, it does though
(spec_ is a std::string), the StringPiece is only valid as long as the Adapter.

+    }
+
+    // GURL can consume UTF-16 directly.
+    return GURL(base::StringPiece16(str.characters16(), str.length()));
+}
+
+} // namespace blink