Reduce string copies in GURL creation

third_party/WebKit/public/platform/WebString.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 #ifndef WebString_h
 #define WebString_h
 
 #include "WebCommon.h"
 #include "WebPrivatePtr.h"
 #include <string>
 
 #if INSIDE_BLINK
 #include "wtf/Forward.h"
 #else
-#include <base/strings/latin1_string_conversions.h>
-#include <base/strings/nullable_string16.h>
-#include <base/strings/string16.h>
+#include "base/strings/latin1_string_conversions.h"
+#include "base/strings/nullable_string16.h"
+#include "base/strings/string16.h"
 #endif
 
 namespace WTF {
 class StringImpl;
 }
 
 namespace blink {
 
 // A UTF-16 string container.  It is inexpensive to copy a WebString
 // object.
@@ skipping 24 matching lines @@
     BLINK_COMMON_EXPORT void assign(const WebUChar* data, size_t len);
 
     BLINK_COMMON_EXPORT bool equals(const WebString&) const;
     BLINK_COMMON_EXPORT bool equals(const char* characters) const;
 
     BLINK_COMMON_EXPORT size_t length() const;
 
     bool isEmpty() const { return !length(); }
     bool isNull() const { return m_private.isNull(); }
 
+    // See also WebStringUTF8Adaptor which will allow getting a UTF-8 buffer
+    // without copying when the string is ASCII.
     BLINK_COMMON_EXPORT std::string utf8() const;
 
     BLINK_COMMON_EXPORT static WebString fromUTF8(const char* data, size_t length);
     BLINK_COMMON_EXPORT static WebString fromUTF8(const char* data);
 
     static WebString fromUTF8(const std::string& s)
     {
         return fromUTF8(s.data(), s.length());
     }
 
@@ skipping 66 matching lines @@
 #endif
 
 private:
     BLINK_COMMON_EXPORT bool is8Bit() const;
     BLINK_COMMON_EXPORT const WebLChar* data8() const;
     BLINK_COMMON_EXPORT const WebUChar* data16() const;
 
     BLINK_COMMON_EXPORT void assign(WTF::StringImpl*);
 
     WebPrivatePtr<WTF::StringImpl> m_private;
+
+    friend class WebStringUTF8Adaptor;

[esprehn, 2016/01/13 02:02:31]

you don't need friends.

 };
 
 inline bool operator==(const WebString& a, const char* b)
 {
     return a.equals(b);
 }
 
 inline bool operator!=(const WebString& a, const char* b)
 {
     return !(a == b);
@@ skipping 15 matching lines @@
 }
 
 inline bool operator!=(const WebString& a, const WebString& b)
 {
     return !(a == b);
 }
 
 } // namespace blink
 
 #endif