Reduce string copies in GURL creation

content/renderer/media/android/webmediaplayer_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/android/webmediaplayer_android.h"
 
 #include <stddef.h>
 
 #include <limits>
 
 #include "base/android/build_info.h"
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "cc/blink/web_layer_impl.h"
 #include "cc/layers/video_layer.h"
+#include "content/public/child/url_conversion.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/renderer_preferences.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/renderer/media/android/renderer_demuxer_android.h"
 #include "content/renderer/media/android/renderer_media_player_manager.h"
 #include "content/renderer/media/cdm/render_cdm_factory.h"
 #include "content/renderer/media/cdm/renderer_cdm_manager.h"
 #include "content/renderer/render_frame_impl.h"
 #include "content/renderer/render_thread_impl.h"
@@ skipping 267 matching lines @@
     return;
   }
   DoLoad(load_type, url, cors_mode);
 }
 
 void WebMediaPlayerAndroid::DoLoad(LoadType load_type,
                                    const blink::WebURL& url,
                                    CORSMode cors_mode) {
   DCHECK(main_thread_checker_.CalledOnValidThread());
 
-  media::ReportMetrics(load_type, GURL(url),
-                       GURL(frame_->document().securityOrigin().toString()));
+  media::ReportMetrics(
+      load_type, GURL(url),
+      WebStringToGURL(frame_->document().securityOrigin().toString()));
 
   switch (load_type) {
     case LoadTypeURL:
       player_type_ = MEDIA_PLAYER_TYPE_URL;
       break;
 
     case LoadTypeMediaSource:
       player_type_ = MEDIA_PLAYER_TYPE_MEDIA_SOURCE;
       break;
 
@@ skipping 1283 matching lines @@
     proxy_decryptor_.reset(new media::ProxyDecryptor(
         media_permission_,
         player_manager_->ShouldUseVideoOverlayForEmbeddedEncryptedVideo(),
         base::Bind(&WebMediaPlayerAndroid::OnKeyAdded,
                    weak_factory_.GetWeakPtr()),
         base::Bind(&WebMediaPlayerAndroid::OnKeyError,
                    weak_factory_.GetWeakPtr()),
         base::Bind(&WebMediaPlayerAndroid::OnKeyMessage,
                    weak_factory_.GetWeakPtr())));
 
-    GURL security_origin(frame_->document().securityOrigin().toString());
+    GURL security_origin(
+        WebStringToGURL(frame_->document().securityOrigin().toString()));
     proxy_decryptor_->CreateCdm(
         cdm_factory_, key_system, security_origin,
         base::Bind(&WebMediaPlayerAndroid::OnCdmContextReady,
                    weak_factory_.GetWeakPtr()));
     current_key_system_ = key_system;
   }
 
   // We do not support run-time switching between key systems for now.
   DCHECK(!current_key_system_.empty());
   if (key_system != current_key_system_)
@@ skipping 307 matching lines @@
 }
 
 void WebMediaPlayerAndroid::ReportHLSMetrics() const {
   if (player_type_ != MEDIA_PLAYER_TYPE_URL)
     return;
 
   bool is_hls = IsHLSStream();
   UMA_HISTOGRAM_BOOLEAN("Media.Android.IsHttpLiveStreamingMedia", is_hls);
   if (is_hls) {
     media::RecordOriginOfHLSPlayback(
-        GURL(frame_->document().securityOrigin().toString()));
+        WebStringToGURL(frame_->document().securityOrigin().toString()));
   }
 
   // Assuming that |is_hls| is the ground truth, test predictions.
   bool is_hls_path = media::MediaCodecUtil::IsHLSPath(url_);
   bool is_hls_url = media::MediaCodecUtil::IsHLSURL(url_);
   MediaTypePredictionResult result = PREDICTION_RESULT_ALL_INCORRECT;
   if (is_hls_path == is_hls && is_hls_url == is_hls) {
     result = PREDICTION_RESULT_ALL_CORRECT;
   } else if (is_hls_path == is_hls) {
     result = PREDICTION_RESULT_PATH_BASED_WAS_BETTER;
   } else if (is_hls_url == is_hls) {
     result = PREDICTION_RESULT_URL_BASED_WAS_BETTER;
   }
   UMA_HISTOGRAM_ENUMERATION(
       "Media.Android.IsHttpLiveStreamingMediaPredictionResult",
       result, PREDICTION_RESULT_MAX);
 }
 
 }  // namespace content