Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 156803004: Merge 250467 "Revert of Add UMA to track app launcher discoverab..." (Closed)

Created:
6 years, 10 months ago by dxie
Modified:
6 years, 10 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, sadrul, tfarina, kalyank, chromium-apps-reviews_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Merge 250467 "Revert of Add UMA to track app launcher discoverab..." > Revert of Add UMA to track app launcher discoverability. (https://codereview.chromium.org/143683004/) > > Reason for revert: > Doesn't compile Google Chrome-branded builds: > > src\chrome\browser\ui\views\app_list\win\app_list_service_win.cc(459) : error C2660: 'AppListServiceImpl::EnableAppList' : function does not take 1 arguments > > Original issue's description: > > Add UMA to track app launcher discoverability. > > > > We want to track effectiveness of the app launcher install education > > pages in enabling users to find, and start using, the app launcher when > > it is auto-enabled upon installing the first v2 packaged app. The > > launcher is not auto-shown for the "first" install, to encourage users > > to learn where it is. > > > > This CL marks "how" the app launcher is enabled (e.g. command line flag, > > webstore, etc.), and when the enable occurs. Then, when the user shows > > the app list, the enable method and time taken to show it is recorded. > > > > We also need to record users that "never" show the app list, or who see > > the app list show automatically upon installing a _second_ app. One hour > > is chosen as a timeout: if no value is recorded after one hour, a value > > is recorded in the "last" bucket for the time taken. > > > > BUG=314235 > > TBR=xiyuan@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250348 > > TBR=benwells@chromium.org,xiyuan@chromium.org,tapted@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=314235 > > Review URL: https://codereview.chromium.org/134303006 TBR=grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -240 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.h View 3 chunks +1 line, -22 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 4 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 6 chunks +6 lines, -98 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_unittest.cc View 10 chunks +9 lines, -70 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_service_ash.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 2 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie
6 years, 10 months ago (2014-02-11 22:45:45 UTC) #1
dxie
6 years, 10 months ago (2014-02-11 22:46:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r250533.

Powered by Google App Engine
This is Rietveld 408576698