Source/core/dom/shadow/ShadowRoot.cpp - Issue 15680005: Element::recalcStyle() overly reattach()-es InsertionPoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 15680005: Element::recalcStyle() overly reattach()-es InsertionPoints. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated test and test expectations Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp

index 83df7d57a0ac95fe239537683a356d2a6f242638..a0153d9041a18ee0155e17d99eaba7c070eacc89 100644

--- a/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/Source/core/dom/shadow/ShadowRoot.cpp

@@ -138,6 +138,13 @@ void ShadowRoot::recalcStyle(StyleChange change)

{

// ShadowRoot doesn't support custom callbacks.

ASSERT(!hasCustomStyleCallbacks());

+ if (!attached()) {

+ attach();

+ // attach recalculates the style for all children. No need to do it twice.

+ clearNeedsStyleRecalc();

+ clearChildNeedsStyleRecalc();

+ return;

+ }

StyleResolver* styleResolver = document()->styleResolver();

styleResolver->pushParentShadowRoot(this);