LayoutTests/fast/dom/shadow/input-color-in-content.html - Issue 15680005: Element::recalcStyle() overly reattach()-es InsertionPoints.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/shadow/input-color-in-content.html

Issue 15680005: Element::recalcStyle() overly reattach()-es InsertionPoints. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated test and test expectations Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../../fast/js/resources/js-test-pre.js"></script>

	5 <div id="host" tabindex="1">

	6 <input id="target" type="color" value="#000000">

	7 </div>

	8 <script>

	9

	10 shadow = host.webkitCreateShadowRoot();

	11 shadow.innerHTML = "<content></content>";

	12 jsTestIsAsync = true;

	13

	14 if (window.eventSender) {

	15 shouldBeFalse("testRunner.isChooserShown()");

	16 eventSender.dragMode = false;

	17 eventSender.mouseMoveTo(target.offsetLeft, target.offsetTop + target.offsetHe ight / 2);

	18 eventSender.mouseDown();

	19 eventSender.mouseUp();

	20 testRunner.setWindowIsKey(false);

	21 window.setTimeout(function() {

	22 window.setTimeout(function() {

	23 shouldBeTrue("testRunner.isChooserShown()");

	24 finishJSTest();

	25 }, 0);

	26 }, 0);
	esprehn 2013/06/13 02:45:40 Btw, these nested setTimeout calls will be flaky. Btw, these nested setTimeout calls will be flaky. I don't think you need all the dragMode or setWindowIsKey stuff either. Nothing ensures that after two set timeouts the chooser will be shown. What's the purpose of this test? The bug referenced is about the value of the color picker, not if the picker is shown. This test passes without your patch.
	27 }

	28

	29 </script>

	30 <script src="../../../fast/js/resources/js-test-post.js"></script>

	31 </body>

	32 </html>

OLD	NEW